[ https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502777#comment-16502777 ]
David Smiley commented on SOLR-12142: ------------------------------------- Now that the SolrTextTagger is in Solr, it's test demonstrating the issue is now here too. See: https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/handler/tagger/EmbeddedSolrNoSerializeTest.java#L102 (the commented out part) If it can't be fixed for 7.4 then the commit ought to be reverted from 7x. > EmbeddedSolrServer should use req.getContentWriter > --------------------------------------------------- > > Key: SOLR-12142 > URL: https://issues.apache.org/jira/browse/SOLR-12142 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: David Smiley > Assignee: Noble Paul > Priority: Major > Fix For: 7.4 > > Attachments: SOLR-12142.patch > > > In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement > for getContentStreams. However, EmbeddedSolrServer still calls > getContentStreams, and so clients who need to send POST data to it cannot yet > switch from the Deprecated API to the new API. The SolrTextTagger is an > example of a project where one would want to do this. > It seems EmbeddedSolrServer ought to check for getContentWriter and if > present then convert it into a ContentStream somehow. For the time being, > ESS needs to call both since both APIs exist. > CC [~noble.paul] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org