[ https://issues.apache.org/jira/browse/LUCENE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506129#comment-16506129 ]
Alessandro Benedetti commented on LUCENE-8343: ---------------------------------------------- First of all, thanks again Adrien for your time. I have done the work for the data type migration approach here : [https://github.com/apache/lucene-solr/pull/398] The patch is affecting many more files as expected, but the strictly BlendedInfixSuggester fix is much more elegant. The drawbacks are that : - much more attention is needed to review the new patch - it should be pretty safe, but introducing nulls around, I never feel fully comfortable unless I am super confident of my tests in case this approach is preferred and someone from the community commit to take care of the review process, I am more than happy to spend more effort in this and make it producton ready! > BlendedInfixSuggester bad score calculus for certain suggestion weights > ----------------------------------------------------------------------- > > Key: LUCENE-8343 > URL: https://issues.apache.org/jira/browse/LUCENE-8343 > Project: Lucene - Core > Issue Type: Bug > Components: core/search > Affects Versions: 7.3.1 > Reporter: Alessandro Benedetti > Priority: Major > Attachments: LUCENE-8343.patch, LUCENE-8343.patch, LUCENE-8343.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Currently the BlendedInfixSuggester return a (long) score to rank the > suggestions. > This score is calculated as a multiplication between : > long *Weight* : the suggestion weight, coming from a document field, it can > be any long value ( including 1, 0,.. ) > double *Coefficient* : 0<=x<=1, calculated based on the position match, > earlier the better > The resulting score is a long, which means that at the moment, any weight<10 > can bring inconsistencies. > *Edge cases* > Weight =1 > Score = 1( if we have a match at the beginning of the suggestion) or 0 ( for > any other match) > Weight =0 > Score = 0 ( independently of the position match coefficient) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org