Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195093742
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -703,6 +703,10 @@ private SolrInputDocument generateExtendedValueDoc(int
ev) throws IOException {
String label = parser.getString();
SolrInputField sif = new SolrInputField(label);
parseFieldValue(sif);
+ // pulling out the pieces may seem weird, but it's because
--- End diff --
It's actually quite refreshing to get another person's opinion.
I don't think it would work flawlessly without changing a lot of the code,
since buildDoc expects a Map as an input, so we would have to parse the map
beforehand.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
