Github user mikemccand commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/398#discussion_r195386599
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/InputIterator.java ---
@@ -34,7 +34,7 @@
public interface InputIterator extends BytesRefIterator {
/** A term's weight, higher numbers mean better suggestions. */
--- End diff --
Maybe add javadocs explaining what `null` means? Though, why do we need to
allow for `null`? Shouldn't the iterator not return a suggestion that has no
weight?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
