[ https://issues.apache.org/jira/browse/LUCENE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520218#comment-16520218 ]
Michael McCandless commented on LUCENE-8367: -------------------------------------------- {quote}Should the DoubleRange equals() compare bits for safety like Double.equals()? Otherwise with == its a bit smelly and buggy (-0 vs 0 and so on). {quote} Oh good catch! Sneaky ... I'll switch to {{Double.equals}}. Thanks [~rcmuir]! > Make per-dimension drill down optional for each facet dimension > --------------------------------------------------------------- > > Key: LUCENE-8367 > URL: https://issues.apache.org/jira/browse/LUCENE-8367 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Michael McCandless > Assignee: Michael McCandless > Priority: Major > Attachments: LUCENE-8367.patch > > > Today, when you index a {{FacetField}} with path {{foo/bar,}} we index two > drill down terms onto the document: {{foo}} and {{foo/bar}}. > But I suspect some users (like me!) don't need to drilldown just on {{foo}} > (effectively "find all documents that have any value for this facet > dimension"), so I added an option to {{FacetsConfig}} to let you specify > per-dimension whether you need to drill down (defaults to true, matching > current behavior). > I also added {{hashCode}} and {{equals}} to the {{LongRange}} and > {{DoubleRange}} classes in facets module, and improved {{CheckIndex}} a bit > to print the total %deletions across the index. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org