[ 
https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521999#comment-16521999
 ] 

Dr Oleg Savrasov commented on SOLR-5211:
----------------------------------------

The patch is reworked according to the latest changes in DirectUpdateHandler2. 
Added test for the case when update has child docs, but there is no _root_ in 
schema. Personally, I'd prefer to move getLuceneDocument and 
getLuceneDocsIfNested from AddUpdateCommand to DirectUpdateHandler2. I believe 
that logic of documents conversion is not responsibility of the command, and 
should be done by handler. Ready to rework the patch if needed.

> updating parent as childless makes old children orphans
> -------------------------------------------------------
>
>                 Key: SOLR-5211
>                 URL: https://issues.apache.org/jira/browse/SOLR-5211
>             Project: Solr
>          Issue Type: Sub-task
>          Components: update
>    Affects Versions: 4.5, 6.0
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Major
>         Attachments: SOLR-5211.patch, SOLR-5211.patch, SOLR-5211.patch
>
>
> if I have parent with children in the index, I can send update omitting 
> children. as a result old children become orphaned. 
> I suppose separate \_root_ fields makes much trouble. I propose to extend 
> notion of uniqueKey, and let it spans across blocks that makes updates 
> unambiguous.  
> WDYT? Do you like to see a test proves this issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to