[ 
https://issues.apache.org/jira/browse/SOLR-12516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522598#comment-16522598
 ] 

Hoss Man commented on SOLR-12516:
---------------------------------

I only discovered this because of a randomized failure from 
{{CurrencyRangeFacetCloudTest}} while testing out SOLR-12343 -- that patch 
(currently) enforces that every shard which has at least one bucket for a field 
facet must "contribute" to every bucket (either in phase#1 or via refinement) 
to be returned -- and it can cause the existing 
{{testJsonRangeFacetWithSubFacet}} to fail for some (randomized) shard count 
because of this bug.

I'll try to work up a more isolated, generalized, test case that shows 
incorrect counts (on a simple/non-currency) for a range facet w/o SOLR-12343 in 
place

> JSON "range" facets don't refine sub-facets under special buckets 
> (before,after,between)
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-12516
>                 URL: https://issues.apache.org/jira/browse/SOLR-12516
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Facet Module
>            Reporter: Hoss Man
>            Priority: Major
>
> {{FacetRangeMerger extends FacetRequestSortedMerger<FacetRange>}} ... however 
> {{FacetRangeMerger}} does not override {{getRefinement(...)}} which means 
> only {{FacetRequestSortedMerger.buckets}} is evaluated and considered for 
> refinement. The additional, special purpose, {{FacetBucket}} instances 
> tracked in {{FacetRangeMerger}} are never considered for refinement.
> In a simple range facet this doesn't cause any problems because these buckets 
> are returned by every shard on the phase#1 request -- but *if a sub-facet 
> (such as a field facet) is nested under a range facet then the buckets 
> returned by the sub-facets for the before/between/after buckets will never be 
> refined* ... the phase#1 sub-facet buckets will be merged as.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to