[ 
https://issues.apache.org/jira/browse/SOLR-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065629#comment-13065629
 ] 

Hoss Man commented on SOLR-1972:
--------------------------------

Shawn: i was a little concerned based on the issue summary that this would slow 
down the performance of the handlers, but skimming the patch i see that unless 
it's explicitly configured in the init params, only a single "responseTimes != 
null" check is added to each request, and even when it is enabled, all the hard 
work is defered until the stats are actually requested -- so as long as we 
document that recording (and retrieving) these stats may slow down the 
performance of hte handler, i don't see a big problem there.  (my personal 
prefrence is to generate these stats from log parsing because then it can be 
done completely out of band -- but i certainly won't object to making it easier 
for people to get directly from solr)

my only other suggestion is that  you refactor the stats code into some static 
methods (or a helper class) so we can have some test cases that verify the 
accuracy against fixed data ... i'm not a match guy, so it's not entirely 
obvious to me just looking at it that it will always produce the correct 
results (particularly with the max age and array re-ordering and what not) so 
unit tests would help demonstrate tht it does what it's suppose to in various 
edge cases.

> Need additional query stats in admin interface - median, 95th and 99th 
> percentile
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-1972
>                 URL: https://issues.apache.org/jira/browse/SOLR-1972
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.4
>            Reporter: Shawn Heisey
>            Priority: Minor
>         Attachments: SOLR-1972.patch, SOLR-1972.patch, SOLR-1972.patch, 
> SOLR-1972.patch, elyograg-1972-3.2.patch, elyograg-1972-3.2.patch, 
> elyograg-1972-trunk.patch, elyograg-1972-trunk.patch
>
>
> I would like to see more detailed query statistics from the admin GUI.  This 
> is what you can get now:
> requests : 809
> errors : 0
> timeouts : 0
> totalTime : 70053
> avgTimePerRequest : 86.59209
> avgRequestsPerSecond : 0.8148785 
> I'd like to see more data on the time per request - median, 95th percentile, 
> 99th percentile, and any other statistical function that makes sense to 
> include.  In my environment, the first bunch of queries after startup tend to 
> take several seconds each.  I find that the average value tends to be useless 
> until it has several thousand queries under its belt and the caches are 
> thoroughly warmed.  The statistical functions I have mentioned would quickly 
> eliminate the influence of those initial slow queries.
> The system will have to store individual data about each query.  I don't know 
> if this is something Solr does already.  It would be nice to have a 
> configurable count of how many of the most recent data points are kept, to 
> control the amount of memory the feature uses.  The default value could be 
> something like 1024 or 4096.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to