[ https://issues.apache.org/jira/browse/LUCENE-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551227#comment-16551227 ]
Dawid Weiss commented on LUCENE-8415: ------------------------------------- Yep, I agree. Doesn't make sense to make FS impls. slower just to enforce it, it's enough that we run tests that capture it early. I'll work on it. > Clean up Directory contracts (write-once, no reads-before-write-completed) > -------------------------------------------------------------------------- > > Key: LUCENE-8415 > URL: https://issues.apache.org/jira/browse/LUCENE-8415 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Dawid Weiss > Assignee: Dawid Weiss > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Created a PR here for early review. > https://github.com/apache/lucene-solr/pull/424 > I changed: > * the wording in Directory documentation to be a bit more formalized about > what rules a Directory should obey (and users expect). > * modified the test framework to verify the above in mock classes. > Currently a number of Directory implementations fail the > {{testReadFileOpenForWrites}} test that I added, so I'll keep working on that. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org