[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552456#comment-16552456 ]
Alan Woodward commented on LUCENE-8038: --------------------------------------- I think it's a bug... we don't really have enough tests around PayloadScoreQuery, and in particular it seems we don't test the case where some positions have a payload and some don't. This is a released issue, would you mind opening a new one? We should change the collector to add back in the condition above, and change the contract of PayloadDecoder to say that it won't accept {{null}} > Decouple payload decoding from Similarity > ----------------------------------------- > > Key: LUCENE-8038 > URL: https://issues.apache.org/jira/browse/LUCENE-8038 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Major > Fix For: 7.2 > > Attachments: LUCENE-8038-master.patch, LUCENE-8038.patch > > > PayloadScoreQuery is the only place that currently uses > SimScorer.computePayloadFactor(), and as discussed on LUCENE-8014, this seems > like the wrong place for it. We should instead add a PayloadDecoder > abstraction that is passed to PayloadScoreQuery. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org