[
https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555903#comment-16555903
]
Adrien Grand commented on SOLR-12587:
-------------------------------------
I think you could fix your first nocommit by passing prepopulate=true to the
constructor and implementing getSentinelObject with {{return proto.copy(); }}.
For your reset() method, you could also take advantage of the fact that
PriorityQueue extends Iterable so you don't need casts or to know that indices
start at 1 in the heap array.
> Reuse Lucene's PriorityQueue for the ExportHandler
> --------------------------------------------------
>
> Key: SOLR-12587
> URL: https://issues.apache.org/jira/browse/SOLR-12587
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Varun Thacker
> Priority: Major
> Labels: export-writer
> Attachments: SOLR-12587.patch
>
>
> We have a priority queue in Lucene {{org.apache.lucene.utilPriorityQueue}} .
> The Export Handler also implements a PriorityQueue
> {{org.apache.solr.handler.export.PriorityQueue}} . Both are obviously very
> similar with minor API differences.
>
> The aim here is to reuse Lucene's PQ and remove the Solr implementation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
