Michael Braun created LUCENE-8433:
-------------------------------------

             Summary: Add FutureArrays.equals(Object[] a, int aToIndex, 
Object[] b, int bFromIndex, int bToIndex)
                 Key: LUCENE-8433
                 URL: https://issues.apache.org/jira/browse/LUCENE-8433
             Project: Lucene - Core
          Issue Type: Improvement
            Reporter: Michael Braun


Noticed code like the following in TopFieldCollector:
{code}
    if (fields1.length > fields2.length) {
      return false;
    }
    return Arrays.asList(fields1).equals(Arrays.asList(fields2).subList(0, 
fields1.length));
{code}
This can be simplified and made more efficient by using Arrays.equals(Object[] 
a, int aToIndex, Object[] b, int bFromIndex, int bToIndex) , which is only 
present in Java 9+. (Though it is not taking advantage of any intrinsics like 
the primitive arrays do, since it uses object equality rather than reference 
equality).  This can be added as part of FutureArrays.java - this would serve 
to simplify code. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to