[ 
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560438#comment-16560438
 ] 

Varun Thacker commented on SOLR-12412:
--------------------------------------

Hi Dat,

Checking again with the doubts that I had regarding this test

First question
{quote}I'm trying to understand the corruptLeader() method : Why are we trying 
to delete segment files after every add ?  What if we just add the 100 docs and 
then delete the segments_N file ? 
{quote}
Second question
{quote}Should we start the otherReplicaJetty and then check if the leader 
doesn't change in the test i.e reverse the order here ? 
{quote}
The reason I ask this again is to me what's the point of starting the jetty and 
putting a code comment that the shard won't be able to do anything without 
actually validating it?
{code:java}
if (otherReplicaJetty != null) {
  // won't be able to do anything here, since this replica can't recovery from 
the leader
  otherReplicaJetty.start();
}{code}

> Leader should give up leadership when IndexWriter.tragedy occur
> ---------------------------------------------------------------
>
>                 Key: SOLR-12412
>                 URL: https://issues.apache.org/jira/browse/SOLR-12412
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Major
>             Fix For: master (8.0), 7.5
>
>         Attachments: SOLR-12412.patch, SOLR-12412.patch, 
> jenkins-failure-2325.log
>
>
> When a leader meets some kind of unrecoverable exception (ie: 
> CorruptedIndexException). The shard will go into the readable state and human 
> has to intervene. 
> In that case, if there are another active replica in the same shard, the 
> leader should give up its leadership.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to