Github user fsparv commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/423#discussion_r206585073
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
 ---
    @@ -272,7 +349,8 @@ private String 
findTargetCollectionGivenTimestamp(Instant docTimestamp) {
             return entry.getValue(); //found it
           }
         }
    -    return null; //not found
    +    throw new SolrException(SolrException.ErrorCode.BAD_REQUEST,
    +        "Doc " + id + " couldn't be routed with " + 
timeRoutedAlias.getRouteField() + "=" + docTimestamp);
    --- End diff --
    
    That would be clearer, I agree


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to