Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/428#discussion_r207699324
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
---
@@ -209,9 +200,8 @@ public void testParseDateFormats() throws Exception {
IndexSchema schema = h.getCore().getLatestSchema();
assertNotNull(schema.getFieldOrNull("dateUTC_dt")); // should match
"*_dt" dynamic field
- String dateTimePattern = "yyyy-MM-dd'T'HH:mm:ss.SSSZ";
- DateTimeFormatter dateTimeFormatterUTC =
DateTimeFormat.forPattern(dateTimePattern);
- DateTime dateTimeUTC =
dateTimeFormatterUTC.parseDateTime(formatExamples[1]);
+ String dateTimePattern = "yyyy-MM-dd'T'HH:mm:ss.SSSZZZZZ";
+ Instant UTCInstant = Instant.parse(formatExamples[1]);
--- End diff --
IMO `UTCInstant` is suggestive that somehow other Instants might not be UTC
yet this one is. An instant is an unambiguous instant in time that has no
relation to time zones. Someone might _express_ / format an instant in a zone,
but the instant itself is neutral to the notion. Perhaps "theInstant" or
"expectInstant" is better as it's the "expect" side of the assert we test in
the loop below.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
