[ 
https://issues.apache.org/jira/browse/SOLR-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated SOLR-12645:
---------------------------------
    Description: 
ResourceLoader#openResource() in this impl always returns null and ignores the 
ByteBuffer with data that it fetched before (it should warp it with an 
InputStream). If ResourceLoader#openResource is not supported, it should throw 
UOE, but returning "null" is against the contract! In addition, it does not ask 
the parent ResourceLoader first (like when finding classes).

This class is completely new to me, but looks like it's used with the plugin 
system. It should be fixed, as it might be passed as ResourceLoader around, 
leading to NPEs.

Any comments what's wrong here?

  was:
ResourceLoader#openResource() in this impl always returns null and ignores the 
ByteBuffer with data that it fetched before (it should warp it with an 
InputStream). If ResourceLoader#openResource is not supported, it should throw 
UOE, but returning "null" is against the contract!

This class is completely new to me, but looks like it's used with the plugin 
system. It should be fixed, as it might be passed as ResourceLoader around, 
leading to NPEs.

Any comments what's wrong here?


> MemClassLoader#loadResource() is broken
> ---------------------------------------
>
>                 Key: SOLR-12645
>                 URL: https://issues.apache.org/jira/browse/SOLR-12645
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Plugin system
>            Reporter: Uwe Schindler
>            Priority: Major
>
> ResourceLoader#openResource() in this impl always returns null and ignores 
> the ByteBuffer with data that it fetched before (it should warp it with an 
> InputStream). If ResourceLoader#openResource is not supported, it should 
> throw UOE, but returning "null" is against the contract! In addition, it does 
> not ask the parent ResourceLoader first (like when finding classes).
> This class is completely new to me, but looks like it's used with the plugin 
> system. It should be fixed, as it might be passed as ResourceLoader around, 
> leading to NPEs.
> Any comments what's wrong here?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to