Github user moshebla commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/416#discussion_r208813169
  
    --- Diff: 
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java
 ---
    @@ -242,10 +242,10 @@ private void testChildDocNonStoredDVFields() throws 
Exception {
             "fl", "*,[child parentFilter=\"subject:parentDocument\"]"), test1);
     
         assertJQ(req("q", "*:*", "fq", "subject:\"parentDocument\" ",
    -        "fl", "subject,[child parentFilter=\"subject:parentDocument\" 
childFilter=\"title:foo\"]"), test2);
    +        "fl", "id,_childDocuments_,subject,intDvoDefault,[child 
parentFilter=\"subject:parentDocument\" childFilter=\"title:foo\"]"), test2);
    --- End diff --
    
    I had to add a small addition and indeed, the behaviour was as expected.
    I added a test to ensure there is backwards compatibility with the old XML 
format 
[here](https://github.com/apache/lucene-solr/blob/2573b89e465de615623084145cab7d17e9cb8a07/solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.java#L100).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to