[ 
https://issues.apache.org/jira/browse/LUCENE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068636#comment-13068636
 ] 

Michael McCandless commented on LUCENE-2795:
--------------------------------------------

I think NativeUnixDir should have a ctor that takes no buffer size, and uses 
the default?  And merging should always use the forcedBufferSize (let's rename 
it to mergeBufferSize?), ie, never delegate to BII.bufferSize(context).

Then, NativeUnixIndexInput/Output shouldn't have 2 ctors, only 1 (that takes 
bufferSize) and NativeUnixDir just passes the buffer size?

Somehow, but this should be a different issue, this Dir impl should only 
provide the II/IO impls for use during merging; if it's not a merge it should 
delegate to another Dir impl.  Maybe we pass a delegate to the ctor or 
something...

> Genericize DirectIOLinuxDir -> UnixDir
> --------------------------------------
>
>                 Key: LUCENE-2795
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2795
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Michael McCandless
>            Assignee: Varun Thacker
>              Labels: gsoc2011, lucene-gsoc-11, mentor
>         Attachments: LUCENE-2795.patch, LUCENE-2795.patch, LUCENE-2795.patch, 
> LUCENE-2795.patch, LUCENE-2795.patch, LUCENE-2795.patch
>
>
> Today DirectIOLinuxDir is tricky/dangerous to use, because you only want to 
> use it for indexWriter and not IndexReader (searching).  It's a trap.
> But, once we do LUCENE-2793, we can make it fully general purpose because 
> then a single native Dir impl can be used.
> I'd also like to make it generic to other Unices, if we can, so that it 
> becomes UnixDirectory.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to