[
https://issues.apache.org/jira/browse/LUCENE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578827#comment-16578827
]
Lucene/Solr QA commented on LUCENE-8449:
----------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} LUCENE-8449 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/lucene-java/HowToContribute#Contributing_your_work for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8449 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12935405/0001-LUCENE-8449-Code-Optimizations-in-FieldTermStack.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/74/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Code Optimizations in FieldTermStack
> ------------------------------------
>
> Key: LUCENE-8449
> URL: https://issues.apache.org/jira/browse/LUCENE-8449
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: Namgyu Kim
> Priority: Minor
> Labels: newbie, performance
> Attachments:
> 0001-LUCENE-8449-Code-Optimizations-in-FieldTermStack.patch
>
>
> -1) "vector.hasPositions() == false" in FieldTermStack's constructor-
> -can be changed to "*!vector.hasPositions()*"-
>
> 2) "public TermInfo(String, int, int, int, float)" constructor
> can be change to "*TermInfo(String, int, int, int, float)*"
>
> 3) TermInfo's toString method
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder();
> sb.append( text ).append( '(' ).append(startOffset).append ( ','
> ).append( endOffset ).append( ',' ).append( position ).append( ')' );
> return sb.toString();
> }{code}
> This code can be changed to
>
> {code:java}
> public String toString(){
> return text + '(' + startOffset + ',' + endOffset + ',' + position + ')';
> }
> {code}
> this code.
>
>
> 4) TermInfo's equals method
> {code:java}
> public boolean equals(Object obj) {
> ...
> if (position != other.position) {
> return false;
> }
> return true;
> }
> {code}
> This code can be changed to
>
> {code:java}
> public boolean equals(Object obj) {
> ...
> return position == other.position;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
