[ 
https://issues.apache.org/jira/browse/SOLR-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584465#comment-16584465
 ] 

Anshum Gupta commented on SOLR-12612:
-------------------------------------

This sounds like a great idea. I'm sure a lot of users have use-cases where a 
cluster/collection level property is desired for plugins/satellite systems.

{quote}I think I'd prefer some parameter in the request to tell Solr if it 
should validate the property or not instead of enforcing some property pattern. 
Something like:
{quote}
In my opinion, the major benefit of having a well defined prefix here is 
ensuring a situation when a user creates a custom plugin to use internally, and 
that uses a property that is at some point used by someone in the community to 
add a totally unrelated plugin.

Such a change would require users to constantly monitor and change code when 
such a clash happens.

I do also agree that strict enforcing/validation of known properties is useful 
to minimize user errors so +1 on the validation too, but that should be in 
addition to a pre-defined prefix for custom props.

Also, I'm not super convinced with 'extra' and me and [~tomasflobbe] were 
talking offline and came up with a few options:
 * external.
 * custom.
 * plugin. 

This is really a subjective thing so wouldn't want this to lead to a random 
debate about the right prefix keyword, but anything that highlights what it's 
used for should work.

> Accept any key in cluster properties
> ------------------------------------
>
>                 Key: SOLR-12612
>                 URL: https://issues.apache.org/jira/browse/SOLR-12612
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.4, master (8.0)
>            Reporter: jefferyyuan
>            Priority: Minor
>             Fix For: master (8.0)
>
>
> Cluster properties is a good place to store configuration data that's shared 
> in the whole cluster: solr and other (authorized) apps can easily read and 
> update them.
>  
> It would be very useful if we can store extra data in cluster properties 
> which would act as a centralized property management system between solr and 
> its related apps (like manager or monitor apps).
>  
> And the change would be also very simple.
> We can also require all extra property starts with prefix like: extra_
>  
> PR: https://github.com/apache/lucene-solr/pull/429
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to