[ https://issues.apache.org/jira/browse/SOLR-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-12679: ----------------------------------------- Summary: MiniSolrCloudCluster internal jetty list should never have duplicates (was: MiniSolrCloudCluster.stopJettySolrRunner should remove jetty from the internal list) > MiniSolrCloudCluster internal jetty list should never have duplicates > --------------------------------------------------------------------- > > Key: SOLR-12679 > URL: https://issues.apache.org/jira/browse/SOLR-12679 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests > Affects Versions: 7.4 > Reporter: Shalin Shekhar Mangar > Assignee: Shalin Shekhar Mangar > Priority: Trivial > Fix For: master (8.0), 7.5 > > Attachments: SOLR-12679.patch > > > MiniSolrCloudCluster has a {{startJettySolrRunner}} method and a > corresponding {{stopJettySolrRunner}} method. While the former adds the given > jetty instance to the internal list of jetty instances, the latter does not > remove the given instance from the list. This leads to inconsistencies e.g. > # If a node is restarted using these two methods, the final list will contain > a duplicate instance of jetty. > # If a node is shutdown, it remains in the list (in the closed state) so > trying to use its method such as getNode will throw an exception > We should fix the {{stopJettySolrRunner}} method to remove the jetty from the > internal list. This change in behavior can potentially break test code but I > think it is a valid bug that should be fixed. > The {{startJettySolrRunner}} method too, adds the given instance to the > internal list without checking whether it exists already or not. That too > should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org