Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/433#discussion_r212802626 --- Diff: solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java --- @@ -94,13 +92,15 @@ private final SolrCmdDistributor cmdDistrib; private final CollectionsHandler collHandler; private final SolrParams outParamsToLeader; + @SuppressWarnings("FieldCanBeLocal") private final CloudDescriptor cloudDesc; private List<Map.Entry<Instant, String>> parsedCollectionsDesc; // k=timestamp (start), v=collection. Sorted descending private Aliases parsedCollectionsAliases; // a cached reference to the source of what we parse into parsedCollectionsDesc private SolrQueryRequest req; + private ExecutorService preemptiveCreationExecutor; --- End diff -- Since it will be nulled out in another thread, we ought to declare this as volatile. I know this is being a bit pedantic since I don't think it'd be a real problem.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org