[
https://issues.apache.org/jira/browse/SOLR-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595133#comment-16595133
]
David Smiley commented on SOLR-5163:
------------------------------------
Thanks for contributing!
I took a brief look at your patch.
* I think DisMaxQParser.parseQueryFields should include validation. Note that
this method is also used by ExtendedDismaxQParser. This method already takes
the schema so it has the necessary inputs.
* Only use the Solr schema "IndexSchema", don't go down to the Lucene level
"FieldInfos".
* It's sufficient to call IndesSchema.getField(name). It'll throw an
exception if it can't, and that exception will be marked as a BAD_REQUEST as it
should be. This method handles dynamic fields; the approach you took would not.
* Missing a test
RE "Timeout waiting for all directory ref counts to be released", I suspect
there was an exception reported prior to that point? Any way this error
surprises me. If after doing the above and adding a test, even if you still
get this error, post the patch any way and I'll take a look then.
> edismax should throw exception when qf refers to nonexistent field
> ------------------------------------------------------------------
>
> Key: SOLR-5163
> URL: https://issues.apache.org/jira/browse/SOLR-5163
> Project: Solr
> Issue Type: Bug
> Components: query parsers, search
> Affects Versions: 4.10.4
> Reporter: Steven Bower
> Priority: Major
> Labels: newdev
> Attachments: SOLR-5163.patch
>
>
> query:
> q=foo AND bar
> qf=field1
> qf=field2
> defType=edismax
> Where field1 exists and field2 doesn't..
> will treat the AND as a term vs and operator
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
