[
https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597757#comment-16597757
]
Stanislav Livotov edited comment on SOLR-12697 at 8/30/18 7:08 PM:
-------------------------------------------------------------------
[~cpoerschke] I have supported both numeric values representations (Point* and
Trie*). And as I understand both of them are tested with different values of
properties like solr.tests.IntegerFieldType. If it is not enough I can
explicitly test both types. Or if you think that support of deprecated
Trie*Fields is not required I can cut this piece of code.
Talking about codebase - in Solr 7.0 as I see DocValues interface was changed,
previously there was just method get by id, now it is iterator with convenient
method advanceExact. However I'm not sure that this realization will work
optimal in all cases, but I've tested that at least for DenseDocValues both
previous and new one method is working exactly the same as before. For
SparseDocValues it is not so but, anyway, I don't see a better way to read from
DocValues.
And I'm not sure, do I need to create a patch for Solr 6? The attached patch
will work for Solr 7 and 8.
was (Author: slivotov):
[~cpoerschke] I have supported both numeric values representations (Point* and
Trie*). And as I understand both of them are tested with different values of
properties like solr.tests.IntegerFieldType. Or if it is not enough I can
explicitly test both types. Or if you think that support of deprecated
Trie*Fields is not required I can cut this peace of code.
Talking about codebase - in Solr 7.0 as I see DocValues interface was changed,
previously there was just method get by id, now it is iterator with convenient
method advanceExact. However I'm not sure that this realization will work
optimal in all cases, but I've tested that at least for DenseDocValues both
previous and new one method is working exactly the same as before. For
SparseDocValues it is not so but, anyway, I don't see a better way to read from
DocValues.
And I'm not sure, do I need to create a patch for Solr 6? The attached patch
will work for Solr 7 and 8.
> pure DocValues support for FieldValueFeature
> --------------------------------------------
>
> Key: SOLR-12697
> URL: https://issues.apache.org/jira/browse/SOLR-12697
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Reporter: Stanislav Livotov
> Priority: Major
> Attachments: SOLR-12697.patch
>
>
> [~slivotov] wrote in SOLR-12688:
> bq. ... FieldValueFeature doesn't support pure DocValues fields (Stored
> false). Please also note that for fields which are both stored and DocValues
> it is working not optimal because it is extracting just one field from the
> stored document. DocValues are obviously faster for such usecases. ...
> (Please see SOLR-12688 description for overall context and analysis results.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
