+1 -- Jan Høydahl, search solution architect Cominvent AS - www.cominvent.com
> 30. aug. 2018 kl. 21:41 skrev Jason Gerlowski <[email protected]>: > > +1 from me > On Thu, Aug 30, 2018 at 3:33 PM Erick Erickson <[email protected]> > wrote: >> >> +1 from me. One of my long-term goals is to gradually work through a >> lot of Solr/Lucene code and get the warnings out. At that point I >> fully intend to make warnings fail on clean code so we don't >> backslide. >> On Thu, Aug 30, 2018 at 11:47 AM David Smiley <[email protected]> >> wrote: >>> >>> It'd be nice to have javac warning-free code. Some modules are already >>> warning-free. Are people ocay with enforcing this constraint (treating >>> warnings as errors) for modules that are already warning-free? >>> >>> I found I could enforce this in one such lucene module (highlighter) by >>> simply adding this: >>> >>> <property name="javac.args" value="-Werror -Xlint -Xlint:-deprecation >>> -Xlint:-serial"/> >>> >>> The "-Werror" is the important part. The rest of the line is copied from >>> common-build.xm. >>> >>> ~ David >>> -- >>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>> http://www.solrenterprisesearchserver.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
