[
https://issues.apache.org/jira/browse/SOLR-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599930#comment-16599930
]
David Smiley commented on SOLR-11861:
-------------------------------------
Thanks Amrit. There were some issues so I updated a new patch:
* modified the v2 API docs to account for the fact that this parameter is no
longer required
* modified the ref guide to mention this parameter now has a default.
* changed the ConfigSetHandler action code:
** use the SolrParams.get(name,default) overloaded version instead doing a null
check after which is more verbose
** changed the "props" line back to how it was, though removing
BASE_CONFIGSET_NAME since that part isn't required. You changed it to use a
deprecated method on SolrParams, so I reverted.
* improved OverseerConfigSetMessageHandler to use the overloaded version of
ZkNodeProps.getStr(name,default) instead doing a null check after which is more
verbose
Upon reflection, it's pretty sad such a simple change has to touch so many
things.
> ConfigSets CREATE baseConfigSet param should default to _default
> ----------------------------------------------------------------
>
> Key: SOLR-11861
> URL: https://issues.apache.org/jira/browse/SOLR-11861
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev
> Attachments: SOLR-11861.patch, SOLR-11861.patch, SOLR-11861.patch,
> SOLR-11861.patch
>
>
> It would be nice if I didn't have to specify the baseConfigSet param now that
> we have a default configSet "_default".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
