Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/443#discussion_r214542721
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java ---
@@ -1831,7 +1831,7 @@ public void testChildDoctransformer() throws
IOException, SolrServerException {
q = new SolrQuery("q", "*:*", "indent", "true");
q.setFilterQueries(parentFilter);
- q.setFields("id,[child parentFilter=\"" + parentFilter +
+ q.setFields("id, level_i, [child parentFilter=\"" + parentFilter +
--- End diff --
I'm confused; this change suggests there is a backwards-compatibility
change; is there? I think you said that the child "fl" is effectively
constrained by whatever the top "fl" is; which if totally true means (I think)
we needn't worry by defaulting to the top "fl". If this isn't totally correct
(hence your change) then we need to be careful about changing the default
behavior in a minor release; we'd have to tweak the default choice (absence of
specific "fl") using the luceneMatchVersion.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
