[
https://issues.apache.org/jira/browse/LUCENE-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602118#comment-16602118
]
Adrien Grand commented on LUCENE-8422:
--------------------------------------
+1 to the patch in general, only two minor comments:
- Maybe we should put some of the helpers that you are adding like
IntervalIterator#wrapMatches or MatchesIterator#disjunction to separate classes
to keep IntervalIterator and MatchesIterator only about consuming
iterators/matches? I think that would make the API easier to digest.
- Should IntervalIterator#wrapMatches return an iterator whose doc ID is
initially -1? Also #docID() should return NO_MORE_DOCS after nextDoc/advance
returned NO_MORE_DOCS.
FYI precommit complains about unused imports.
> Add Matches iteration to interval queries
> -----------------------------------------
>
> Key: LUCENE-8422
> URL: https://issues.apache.org/jira/browse/LUCENE-8422
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Attachments: LUCENE-8422.patch, LUCENE-8422.patch
>
>
> Follow up to LUCENE-8404, we can now add Matches iteration to interval
> queries in the sandbox.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
