Varun Thacker created SOLR-12734:
------------------------------------
Summary: Don't capture certain admin handler metrics
Key: SOLR-12734
URL: https://issues.apache.org/jira/browse/SOLR-12734
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Varun Thacker
Assignee: Varun Thacker
I just had a user who confused the metrics we show for the zookeeper admin
handler and think this was actual ZooKeeper metrics
For example metrics like these
{code:java}
"ADMIN./admin/zookeeper.clientErrors":{
"count":0,
"meanRate":0.0,
"1minRate":0.0,
"5minRate":0.0,
"15minRate":0.0},
"ADMIN./admin/zookeeper.errors":{
"count":0,
"meanRate":0.0,
"1minRate":0.0,
"5minRate":0.0,
"15minRate":0.0},
"ADMIN./admin/zookeeper.handlerStart":1536093060895,
"ADMIN./admin/zookeeper.requestTimes":{
"count":0,
"meanRate":0.0,
"1minRate":0.0,
"5minRate":0.0,
"15minRate":0.0,
"min_ms":0.0,
"max_ms":0.0,
"mean_ms":0.0,
"median_ms":0.0,
"stddev_ms":0.0,
"p75_ms":0.0,
"p95_ms":0.0,
"p99_ms":0.0,
"p999_ms":0.0},{code}
Thinking about this these metrics don't seem useful at all to me and would just
confuse users
My proposal is to remove the metrics we display for the following admin
handlers as they don't add any value and reduces the verbosity of the response
{code:java}
/admin/info
/admin/configs
/admin/zookeeper
/admin/zookeeper/status
/admin/info/system
/admin/metrics/history
/admin/autoscaling
/admin/autoscaling/history
/admin/autoscaling/diagnostics
/admin/autoscaling/suggestions{code}
Admin handlers that we should still keep metrics . These might be helpful to
some user who wants to see how many requests fail, how many times is my
monitoring tool calling the metrics API etc
{code:java}
/admin/health
/admin/authentication
/admin/authorization
/admin/metrics
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
