[ https://issues.apache.org/jira/browse/LUCENE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607327#comment-16607327 ]
Lucene/Solr QA commented on LUCENE-8347: ---------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 43s{color} | {color:green} suggest in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 2m 46s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-8347 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12926717/LUCENE-8347.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 6fbcda6 | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | 1.8.0_172 | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/89/testReport/ | | modules | C: lucene/suggest U: lucene/suggest | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/89/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > BlendedInfixSuggester to handle multi term matches better > --------------------------------------------------------- > > Key: LUCENE-8347 > URL: https://issues.apache.org/jira/browse/LUCENE-8347 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Affects Versions: 7.3.1 > Reporter: Alessandro Benedetti > Priority: Major > Attachments: LUCENE-8347.patch, LUCENE-8347.patch > > > Currently the blendedInfix suggester considers just the first match position > when scoring a suggestion. > From the lucene-dev mailing list : > " > If I write more than one term in the query, let's say > > "Mini Bar Fridge" > > I would expect in the results something like (note that allTermsRequired=true > and the schema weight field always returns 1000) > > - *Mini Bar Fridge* something > - *Mini Bar Fridge* something else > - *Mini Bar* something *Fridge* > - *Mini Bar* something else *Fridge* > - *Mini* something *Bar Fridge* > ... > > Instead I see this: > > - *Mini Bar* something *Fridge* > - *Mini Bar* something else *Fridge* > - *Mini Bar Fridge* something > - *Mini Bar Fridge* something else > - *Mini* something *Bar Fridge* > ... > > After having a look at the suggester code > (BlendedInfixSuggester.createCoefficient), I see that the component takes in > account only one position, which is the lowest position (among the three > matching terms) within the term vector ("mini" in the example above) so all > the suggestions above have the same weight > " > Scope of this Jira issue is to improve the BlendedInfix to better manage > those scenarios. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org