[ https://issues.apache.org/jira/browse/LUCENE-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608564#comment-16608564 ]
Lucene/Solr QA commented on LUCENE-8489: ---------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 30s{color} | {color:green} core in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 13m 47s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-8489 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12938995/LUCENE-8489.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / f406ff9 | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | 1.8.0_172 | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/91/testReport/ | | modules | C: lucene/core U: lucene/core | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/91/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Provide List type constructors for BaseCompositeReader based Readers > -------------------------------------------------------------------- > > Key: LUCENE-8489 > URL: https://issues.apache.org/jira/browse/LUCENE-8489 > Project: Lucene - Core > Issue Type: Improvement > Components: core/index > Reporter: Namgyu Kim > Priority: Major > Labels: usability > Attachments: LUCENE-8489.patch > > > Currently, Reader based on BaseCompositeReader(MultiReader, > ParallelCompositeReader, DirectoryReader) does not support List type > constructor. > In fact, this does not make a big difference in performance, but users will > think positively if the API supports more variants. > I will add the following to support this. > 1) MultiReader > {code:java} > public MultiReader(List<IndexReader> subReaders) throws IOException { > this(subReaders, true); > } > public MultiReader(List<IndexReader> subReaders, boolean closeSubReaders) > throws IOException { > this(subReaders.toArray(new IndexReader[0]), closeSubReaders); > } > {code} > 2) ParallelCompositeReader > {code:java} > public ParallelCompositeReader(List<CompositeReader> readers) throws > IOException { > this(true, readers); > } > public ParallelCompositeReader(boolean closeSubReaders, List<CompositeReader> > readers) throws IOException { > this(closeSubReaders, readers, readers); > } > public ParallelCompositeReader(boolean closeSubReaders, List<CompositeReader> > readers, List<CompositeReader> storedFieldReaders) throws IOException { > this(closeSubReaders, readers.toArray(new CompositeReader[0]), > storedFieldReaders.toArray(new CompositeReader[0])); > } > {code} > 3) DirectoryReader > {code:java} > protected DirectoryReader(Directory directory, List<LeafReader> > segmentReaders) throws IOException { > super(segmentReaders); > this.directory = directory; > } > {code} > 4) BaseCompositeReader > {code:java} > @SuppressWarnings("unchecked") > protected BaseCompositeReader(List<R> subReaders) throws IOException { > this(subReaders.toArray((R[]) new IndexReader[subReaders.size()])); > } > {code} > 5) Test > I wrote a test case in "TestParallelCompositeReader". > If you have any questions or requests, please left any comments :D -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org