[ https://issues.apache.org/jira/browse/LUCENE-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617309#comment-16617309 ]
Simon Willnauer commented on LUCENE-8503: ----------------------------------------- The reality is that unwrapping happens all over the place even in our codebase. I suspect this is a common problem if you start work with reader hierarchies. I wonder if you would ever see this interface if you don't work with expert API. In this case I think we just make our live easier without risking anything. > Simplify unwrapping Filter*Reader > --------------------------------- > > Key: LUCENE-8503 > URL: https://issues.apache.org/jira/browse/LUCENE-8503 > Project: Lucene - Core > Issue Type: Improvement > Affects Versions: 7.5, master (8.0) > Reporter: Simon Willnauer > Priority: Major > Fix For: 7.6, master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Today we have 3 different kinds of FilterIndexReader. While > FilterDirecotryReader > and FilterLeafReader are simple to distinguish, FilterCodecReader make > decision harder > since now we need instanceof checks to deside which unwrap method we > should call. This > adds a simple interface that allows to build generic unwrap methods to > access the delegat > of each of the filtering readers. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org