[
https://issues.apache.org/jira/browse/SOLR-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618178#comment-16618178
]
Hoss Man commented on SOLR-12759:
---------------------------------
nitpick...
in the case of "broken in current RC of third-party X" type test
assumptions/workarounds, i think we should try as much as possible to ensure
that the the assumption/workaround starts failing loudly once the underlying
third-party bug is fixed, so we don't inadvertently leave a bunch of tests
disabled forever.
Maybe something like this (unless i've got my logic backwards)...
{code:java}
final boolean brokenJDKDates = someMethodThatReturnsFalseIfJDK11IsBroken();
if (brokenJDKDates) {
asumeTrue("SOLR-12759 JDK 11 RCs currently don't work",
System.getProperty("java.version").startsWith("11"));
} else {
asumeFalse("SOLR-12759 JDK 11 RCs are not expected to work, apparently they
do now, test should be updated",
System.getProperty("java.version").startsWith("11"));
}{code}
> Disable ExtractingRequestHandlerTest on JDK 11
> ----------------------------------------------
>
> Key: SOLR-12759
> URL: https://issues.apache.org/jira/browse/SOLR-12759
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - Solr Cell (Tika extraction)
> Environment: JDK 11 and Tika 1.x
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 7.6
>
>
> ExtractingRequestHandlerTest has failed on a JDK 11 RC due to two conspiring
> problems: (A) Tika 1.x sometimes calls Date.toString() when extracting
> metadata (unreleased 2.x will fix this), (B) JDK 11 RC has a bug in some
> locales like Arabic in which a Date.toString() will have a timezone offset
> using its locale's characters for the digits instead of using EN_US.
> I'll add an "assume" check so we don't see failures about this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
