[ https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627164#comment-16627164 ]
Lucene/Solr QA commented on SOLR-12652: --------------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 24s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 49m 22s{color} | {color:red} core in the patch failed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 54m 7s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | solr.metrics.SolrMetricsIntegrationTest | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-12652 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12941104/SOLR-12652.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 2bad3c4 | | ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 | | Default Java | 1.8.0_172 | | unit | https://builds.apache.org/job/PreCommit-SOLR-Build/188/artifact/out/patch-unit-solr_core.txt | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/188/testReport/ | | modules | C: solr solr/core U: solr | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/188/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > SolrMetricManager.overridableRegistryName should be removed; it doesn't work > ---------------------------------------------------------------------------- > > Key: SOLR-12652 > URL: https://issues.apache.org/jira/browse/SOLR-12652 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics > Affects Versions: 7.1 > Reporter: David Smiley > Priority: Minor > Attachments: SOLR-12652.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{SolrMetricManager.overridableRegistryName()}} method is a great idea > but unfortunately in practice I've found it doesn't really work; it seems > fundamentally flawed. +I wish it could work+. The main issue I think is > that the callers of SMM.registerGauge/registerMetric assumes it can place a > gauge/metric and have it be the only once there (force==true). But it won't > be if it's shared. > Another problem is in at least one of the reporters -- > {{JmxMetricsReporter.JmxListener#registerMBean}} will get in a race condition > to remove an already-registered MBean but in the process of removing it, > it'll already get removed concurrently by some other core working on the same > name. This results in {{javax.management.InstanceNotFoundException}} logged > as a warning; nothing serious. But I suspect conceptually there is a problem > since which MBean should "win"? Shrug. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org