[
https://issues.apache.org/jira/browse/SOLR-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628668#comment-16628668
]
Shalin Shekhar Mangar edited comment on SOLR-12756 at 9/26/18 12:10 PM:
------------------------------------------------------------------------
This patch passes all tests. Now to remove the last few nocommits such as
trying to merge the Assign2 and Assign classes, merge identifyNodes and
getNodesForNewReplicas method and getting rid of the ZkNodeProps instance being
passed around.
was (Author: shalinmangar):
This patch passes all tests. Now to remove the last few nocommits such as
trying to unify the identifyNodes and getNodesForNewReplicas method, getting
rid of the ZkNodeProps instance being passed around.
> Refactor Assign and extract replica placement strategies out of it
> ------------------------------------------------------------------
>
> Key: SOLR-12756
> URL: https://issues.apache.org/jira/browse/SOLR-12756
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 7.6, master (8.0)
>
> Attachments: SOLR-12756.patch, SOLR-12756.patch, SOLR-12756.patch
>
>
> While working on SOLR-12648, I found Assign class to be very complex. Many
> methods have overlapping functionality, differ in side-effects and have
> non-intuitive arguments. We should clean this up and extract replica
> placement strategies out of that class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
