[ 
https://issues.apache.org/jira/browse/LUCENE-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638070#comment-16638070
 ] 

Ignacio Vera edited comment on LUCENE-8520 at 10/4/18 1:08 PM:
---------------------------------------------------------------

I have a look into this error and it looks like the test is incorrect now as we 
do not count total hits by default. 

Attached is a patch that performs the query so that all hits are computed. 


was (Author: ivera):
I have a look into this error and it looks like the test is incorrect now as we 
do not count total hots by default. 

Attached is a patch that performs the query so that all hits are computed. 

> TestIndexWriterMaxDocs.testExactlyAtTrueLimit() failure
> -------------------------------------------------------
>
>                 Key: LUCENE-8520
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8520
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Steve Rowe
>            Priority: Major
>         Attachments: LUCENE-8520.patch
>
>
> From my Jenkins 
> [http://jenkins.sarowe.net/job/Lucene-core-weekly-monster-master-HDD/365/], 
> reproduces for me locally:
> {noformat}
> Checking out Revision 964cc88cee7d62edf03a923e3217809d630af5d5 
> (refs/remotes/origin/master)
> [...]
>    [junit4] Suite: org.apache.lucene.index.TestIndexWriterMaxDocs
>    [junit4]   2> NOTE: reproduce with: ant test  
> -Dtestcase=TestIndexWriterMaxDocs -Dtests.method=testExactlyAtTrueLimit 
> -Dtests.seed=4544F11B4D9BB14C -Dtests.nightly=true -Dtests.slow=true 
> -Dtests.monster=true -Dtests.locale=ko-KR -Dtests.timezone=Atlantic/Jan_Mayen 
> -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
>    [junit4] FAILURE 1597s J0 | TestIndexWriterMaxDocs.testExactlyAtTrueLimit 
> <<<
>    [junit4]    > Throwable #1: java.lang.AssertionError: 
> expected:<2147483519> but was:<2165>
>    [junit4]    >      at 
> __randomizedtesting.SeedInfo.seed([4544F11B4D9BB14C:AAE52DEAF347C094]:0)
>    [junit4]    >      at 
> org.apache.lucene.index.TestIndexWriterMaxDocs.testExactlyAtTrueLimit(TestIndexWriterMaxDocs.java:71)
>    [junit4]    >      at java.lang.Thread.run(Thread.java:748)
>    [junit4]   2> NOTE: leaving temporary files on disk at: 
> /slow/jenkins/HDD-workspaces/Lucene-core-weekly-monster-master-HDD/lucene/build/core/test/J0/temp/lucene.index.TestIndexWriterMaxDocs_4544F11B4D9BB14C-001
>    [junit4]   2> Sep 30, 2018 6:47:23 PM 
> com.carrotsearch.randomizedtesting.ThreadLeakControl checkThreadLeaks
>    [junit4]   2> WARNING: Will linger awaiting termination of 1 leaked 
> thread(s).
>    [junit4]   2> Sep 30, 2018 6:47:43 PM 
> com.carrotsearch.randomizedtesting.ThreadLeakControl checkThreadLeaks
>    [junit4]   2> SEVERE: 1 thread leaked from SUITE scope at 
> org.apache.lucene.index.TestIndexWriterMaxDocs: 
>    [junit4]   2>    1) Thread[id=2505, name=Lucene Merge Thread #13, 
> state=RUNNABLE, group=TGRP-TestIndexWriterMaxDocs]
>    [junit4]   2>         at 
> org.apache.lucene.codecs.PushPostingsWriterBase.writeTerm(PushPostingsWriterBase.java:148)
>    [junit4]   2>         at 
> org.apache.lucene.codecs.blocktree.BlockTreeTermsWriter$TermsWriter.write(BlockTreeTermsWriter.java:865)
>    [junit4]   2>         at 
> org.apache.lucene.codecs.blocktree.BlockTreeTermsWriter.write(BlockTreeTermsWriter.java:344)
>    [junit4]   2>         at 
> org.apache.lucene.codecs.FieldsConsumer.merge(FieldsConsumer.java:105)
>    [junit4]   2>         at 
> org.apache.lucene.codecs.perfield.PerFieldPostingsFormat$FieldsWriter.merge(PerFieldPostingsFormat.java:165)
>    [junit4]   2>         at 
> org.apache.lucene.index.SegmentMerger.mergeTerms(SegmentMerger.java:244)
>    [junit4]   2>         at 
> org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:139)
>    [junit4]   2>         at 
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4453)
>    [junit4]   2>         at 
> org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4075)
>    [junit4]   2>         at 
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:625)
>    [junit4]   2>         at 
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:662)
>    [junit4]   2> Sep 30, 2018 6:47:43 PM 
> com.carrotsearch.randomizedtesting.ThreadLeakControl tryToInterruptAll
>    [junit4]   2> INFO: Starting to interrupt leaked threads:
>    [junit4]   2>    1) Thread[id=2505, name=Lucene Merge Thread #13, 
> state=RUNNABLE, group=TGRP-TestIndexWriterMaxDocs]
>    [junit4]   2> Sep 30, 2018 6:47:43 PM 
> com.carrotsearch.randomizedtesting.ThreadLeakControl tryToInterruptAll
>    [junit4]   2> INFO: All leaked threads terminated.
>    [junit4]   2> NOTE: test params are: codec=Lucene80, 
> sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@72a4d8a0),
>  locale=ko-KR, timezone=Atlantic/Jan_Mayen
>    [junit4]   2> NOTE: Linux 4.1.0-custom2-amd64 amd64/Oracle Corporation 
> 1.8.0_151 (64-bit)/cpus=16,threads=1,free=616857624,total=1299185664
>    [junit4]   2> NOTE: All tests run in this JVM: [TestBasicModelIn, 
> TestSparseFixedBitDocIdSet, TestAutomaton, TestRegExp, 
> TestReaderWrapperDVTypeCheck, TestMultiMMap, 
> TestLucene50StoredFieldsFormatHighCompression, TestNoMergeScheduler, 
> TestLazyProxSkipping, TestPayloads, Test4GBStoredFields, TestShardSearching, 
> TestTwoPhaseCommitTool, TestTermVectorsReader, TestFloatRangeFieldQueries, 
> TestLSBRadixSorter, TestSloppyPhraseQuery2, TestIndexManyDocuments, 
> TestPrefixCodedTerms, TestSoftDeletesRetentionMergePolicy, 
> TestIndexWriterDelete, TestFixedBitDocIdSet, TestConjunctions, 
> TestBagOfPostings, TestMultiTermsEnum, TestIndexWriterThreadsToSegments, 
> TestRAMDirectory, TestMatchNoDocsQuery, TestFutureArrays, 
> TestLatLonDocValuesField, TestDateTools, TestBufferedIndexInput, 
> TestAssertions, TestIndexWriterForceMerge, TestPhraseQuery, 
> TestDeterminizeLexicon, TestDocValuesRewriteMethod, TestArrayUtil, 
> TestDelegatingAnalyzerWrapper, TestCheckIndex, TestCodecUtil, TestDateSort, 
> TestDirectoryReaderReopen, TestDocumentsWriterStallControl, 
> TestDocsAndPositions, TestIndexWriterOnJRECrash, TestFilterMergePolicy, 
> TestNeverDelete, TestBoolean2ScorerSupplier, 
> TestTopFieldCollectorEarlyTermination, TestCharTermAttributeImpl, 
> TestStressIndexing, TestIndexedDISI, TestSpanExplanations, TestOmitPositions, 
> TestReqOptSumScorer, TestIntArrayDocIdSet, TestIndependenceStandardized, 
> TestForUtil, TestQueryBuilder, TestMixedDocValuesUpdates, TestCustomTermFreq, 
> TestBooleanQueryVisitSubscorers, TestMultiCollector, 
> TestLucene70SegmentInfoFormat, TestPerFieldDocValuesFormat, 
> TestPerFieldPostingsFormat2, TestBinaryDocument, TestField, TestFieldType, 
> TestFloatRange, TestIntRange, TestLongDistanceFeatureQuery, TestPolygon, 
> TestPolygon2D, Test2BBinaryDocValues, Test2BSortedDocValuesOrds, 
> TestAllFilesHaveChecksumFooter, TestAllFilesHaveCodecHeader, TestCodecs, 
> TestConcurrentMergeScheduler, TestConsistentFieldNumbers, TestCrash, 
> TestDemoParallelLeafReader, TestDirectoryReader, 
> TestDocInverterPerFieldErrorInfo, TestDocValues, TestExitableDirectoryReader, 
> TestFieldInfos, TestFieldInvertState, TestFieldReuse, TestFieldsReader, 
> TestFilterCodecReader, TestFlushByRamOrCountsPolicy, TestForTooMuchCloning, 
> TestForceMergeForever, TestIndexCommit, TestIndexFileDeleter, TestIndexInput, 
> TestIndexTooManyDocs, TestIndexWriter, TestIndexWriterCommit, 
> TestIndexWriterConfig, TestIndexWriterExceptions, TestIndexWriterExceptions2, 
> TestIndexWriterLockRelease, TestIndexWriterMaxDocs]
>    [junit4]   2> NOTE: reproduce with: ant test  
> -Dtestcase=TestIndexWriterMaxDocs -Dtests.seed=4544F11B4D9BB14C 
> -Dtests.nightly=true -Dtests.slow=true -Dtests.monster=true 
> -Dtests.locale=ko-KR -Dtests.timezone=Atlantic/Jan_Mayen -Dtests.asserts=true 
> -Dtests.file.encoding=US-ASCII
>    [junit4] ERROR   0.00s J0 | TestIndexWriterMaxDocs (suite) <<<
>    [junit4]    > Throwable #1: 
> com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from 
> SUITE scope at org.apache.lucene.index.TestIndexWriterMaxDocs: 
>    [junit4]    >    1) Thread[id=2505, name=Lucene Merge Thread #13, 
> state=RUNNABLE, group=TGRP-TestIndexWriterMaxDocs]
>    [junit4]    >         at 
> org.apache.lucene.codecs.PushPostingsWriterBase.writeTerm(PushPostingsWriterBase.java:148)
>    [junit4]    >         at 
> org.apache.lucene.codecs.blocktree.BlockTreeTermsWriter$TermsWriter.write(BlockTreeTermsWriter.java:865)
>    [junit4]    >         at 
> org.apache.lucene.codecs.blocktree.BlockTreeTermsWriter.write(BlockTreeTermsWriter.java:344)
>    [junit4]    >         at 
> org.apache.lucene.codecs.FieldsConsumer.merge(FieldsConsumer.java:105)
>    [junit4]    >         at 
> org.apache.lucene.codecs.perfield.PerFieldPostingsFormat$FieldsWriter.merge(PerFieldPostingsFormat.java:165)
>    [junit4]    >         at 
> org.apache.lucene.index.SegmentMerger.mergeTerms(SegmentMerger.java:244)
>    [junit4]    >         at 
> org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:139)
>    [junit4]    >         at 
> org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:4453)
>    [junit4]    >         at 
> org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4075)
>    [junit4]    >         at 
> org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:625)
>    [junit4]    >         at 
> org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:662)
>    [junit4]    >      at 
> __randomizedtesting.SeedInfo.seed([4544F11B4D9BB14C]:0)
>    [junit4] Completed [321/510 (1!)] on J0 in 1634.90s, 21 tests, 1 failure, 
> 1 error <<< FAILURES!
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to