On 10/10/2018 5:40 PM, Shawn Heisey wrote:
somebody who's intimately familiar with that code could decipher it a
lot faster than I can.
I went ahead and built a test class mirroring the sorting code I see in
ConcurrentMergeScheduler (master branch), and it looks like current code
does indeed behave as advertised. Here's the code I built (paste has a
one month expiration time):
https://apaste.info/CFJT
The output of that class is this, exactly what I was hoping to see:
Index: 0, Size: 4725, Pause: true
Index: 1, Size: 3725, Pause: true
Index: 2, Size: 2725, Pause: true
Index: 3, Size: 1725, Pause: true
Index: 4, Size: 725, Pause: true
Index: 5, Size: 525, Pause: false
Index: 6, Size: 25, Pause: false
The code could use more comments documenting its operation, but it does
look like it's correct, at least in the master branch.
Looking over the commit history for the file, nothing jumped out at me
as being a change that might have reversed the sort order, but I can say
that Solr 1.4.x (Lucene 2.9) is where I saw the problem, and I'm
reasonably certain that some of the reports I handled on the mailing
list were on version 4.x. I cannot confirm the version on more recent
reports without checking list history.
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
