Optimize memory usage in JavaBinCodec.readStr() -----------------------------------------------
Key: SOLR-2679 URL: https://issues.apache.org/jira/browse/SOLR-2679 Project: Solr Issue Type: Improvement Components: clients - java, Response Writers, update Affects Versions: 3.3 Reporter: Maxim Valyanskiy Fix For: 3.4 In Solr 3.3, JavaBinCodec.readStr() reads complete string into byte[] and then converts it into String. FastInputStream is already buffered, so this it not necessary and may take a lot of memory if data string is large. This patch replaces usage of big byte[] with usage of dis.readUnsignedByte() for getting characters directly from stream. Patch reduces memory usage and may slightly improve performance of reading text data in javabin-codec. JavaBinCodec.readStr() function already has unit test in TestJavaBinCodec, no additional unit test is required. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org