[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654556#comment-16654556 ]
Erick Erickson commented on SOLR-10465: --------------------------------------- Not sure the linking is working, so repeating SOLR-11868. I suggest we rename this to something else, perhaps "withRoutingField"? The linked Jira points out that this really has nothing to do with any field named "id", whether it's a <uniqueKey> or not. It's really the field used for computing what shard the doc goes to whether it's "id" or something totally different. If this gets committed, please close the linked Jira as well. > setIdField should be deprecated in favor of SolrClientBuilder methods > --------------------------------------------------------------------- > > Key: SOLR-10465 > URL: https://issues.apache.org/jira/browse/SOLR-10465 > Project: Solr > Issue Type: Sub-task > Components: SolrJ > Reporter: Jason Gerlowski > Priority: Minor > Fix For: 7.0 > > Attachments: SOLR-10465.patch > > > Now that builders are in place for {{SolrClients}}, the setters used in each > {{SolrClient}} can be deprecated, and their functionality moved over to the > Builders. This change brings a few benefits: > - unifies {{SolrClient}} configuration under the new Builders. It'll be nice > to have all the knobs, and levers used to tweak {{SolrClient}}s available in > a single place (the Builders). > - reduces {{SolrClient}} thread-safety concerns. Currently, clients are > mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" > behavior when the clients are used across multiple threads. > This subtask endeavors to change this behavior for the {{setIdField}} setter > on all {{SolrClient}} implementations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org