Github user gerlowskija commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/464#discussion_r227024512 --- Diff: solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java --- @@ -1260,16 +1248,14 @@ public void testBoolQuery() throws Exception { "must='{!lucene}foo_s:c' filter='{!lucene}foo_s:d' filter='{!lucene}foo_s:e'}", "{!bool must='{!lucene}foo_s:c' filter='{!lucene}foo_s:d' " + "must_not='{!lucene}foo_s:a' should='{!lucene}foo_s:b' filter='{!lucene}foo_s:e'}"); - try { - assertQueryEquals - ("bool" - , "{!bool must='{!lucene}foo_s:a'}" - , "{!bool should='{!lucene}foo_s:a'}" - ); - fail("queries should not have been equal"); - } catch(AssertionFailedError e) { - assertTrue("queries were not equal, as expected", true); - } + + expectThrows(AssertionFailedError.class, "queries were not equal, as expected", --- End diff -- [-1] ditto re: wrong String message in `expectThrows` here
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org