[
https://issues.apache.org/jira/browse/SOLR-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662371#comment-16662371
]
David Smiley commented on SOLR-12895:
-------------------------------------
While I think this solution is okay... it may introduce a performance hit if
the query contains a MTQ -- and this parser can produce a PrefixQuery (an MTQ),
though it appears nothing else. But at least the solution is easy and will
make the highlighting work out of the box.
Another solution path is to insist that someone using this query parser should
set hl.offsetSource= (whatever) and furthermore we make changes in
UnifiedSolrHighlighter that make this value stick instead of getting optimized
away to NONE_NEEDED. That, together with the new hl.weightMatches, should make
this work reasonably efficiently. Granted if say you have offsets in postings
but no term vectors, we'll always assume you need to do analysis since we're
not certain what the query contains (wether it has an MTQ or not).
I don't really like it when query parsers produce Query subclasses internal to
the workings of the query parser. ComplexPhraseQParserPlugin also does this
and is similarly affected. I'm not certain if these parsers need to do this or
not. That could be another avenue to fix the problem.
> SurroundQParserPlugin support for UnifiedHighlighter
> ----------------------------------------------------
>
> Key: SOLR-12895
> URL: https://issues.apache.org/jira/browse/SOLR-12895
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Attachments: SOLR-12895.patch, SOLR-12895.patch
>
>
> The "surround" QParser doesn't work with the UnififedHighlighter --
> LUCENE-8492. However I think we can overcome this by having Solr's QParser
> extend getHighlightQuery and rewrite itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
