[
https://issues.apache.org/jira/browse/SOLR-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663790#comment-16663790
]
David Smiley commented on SOLR-7557:
------------------------------------
This PR looks good to me. It should work both for "anonymous" child docs (as
the test here is doing) and the newer field-labelled child docs at any nested
depth.
I do think SolrExampleTestsBase is a better home for this -- either the
provided test or extending testStreamingRequest to be more comprehensive for
this case.
> Solrj doesn't handle child documents when using queryAndStreamResponse
> ----------------------------------------------------------------------
>
> Key: SOLR-7557
> URL: https://issues.apache.org/jira/browse/SOLR-7557
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
> Affects Versions: 5.4
> Reporter: Stian Østerhaug
> Assignee: Jan Høydahl
> Priority: Major
> Fix For: 7.6, master (8.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Getting the results from a query that as child documents results in "parsing
> error" when using SolrClient's queryAndStreamResponse(), but not when using
> the regular query() method.
> The bug is caused by StreamingBinaryResponseParser's JavaBinCodec override of
> readSolrDocument which always returns null (the document is instead passed to
> the callback), but JavaBinCodec uses the method to also decode child
> documents.
> I have fixed this by using a simple nestedLevel variable that can be used to
> detect if the document being parsed is a child (and should be returned) or a
> parent (and should be passed to the callback).
> The fix feels kinda hacky, but it is simple. Link to a Github pull request to
> follow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
