[
https://issues.apache.org/jira/browse/SOLR-12931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664371#comment-16664371
]
Varun Thacker commented on SOLR-12931:
--------------------------------------
Context to the quesion : I started looking at SOLR-12906 and
DelayingSearchComponent caught my eye as it was under the (
org.apache.solr.search ) package. After spending a couple of minutes I figured
this has to do with tests around ExitableDirectoryReader
Let's use ExitableDirectoryReader as the feature in context that we wanted to
test - We wrote a test for single core and then a cloud test. I think this is a
typical pattern where the single core test can be more exhaustive, but we want
to write a cloud test to make sure it works in the distributed case as well
Both are integration tests.
DelayingSearchComponent is the helper class and in the ( org.apache.solr.search
) package
CloudExitableDirectoryReaderTest is the test that uses this and is in the (
org.apache.solr.cloud ) package
ExitableDirectoryReaderTest is the single core test for this in the (
org.apache.solr.core ) package
Proposing that we move these three classes to it's own package as a first pass.
When we make a clear distinction of mock vs integration tests we could move
this package under integration
> Move Solr's ExitableDirectoryReader test to it's own package
> ------------------------------------------------------------
>
> Key: SOLR-12931
> URL: https://issues.apache.org/jira/browse/SOLR-12931
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
