[ https://issues.apache.org/jira/browse/LUCENE-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672177#comment-16672177 ]
Nicholas Knize commented on LUCENE-8549: ---------------------------------------- Nice convenience method, and the patch is small and straightforward. Can you add the explicit testing to {{TestTessellator}}. Then +1 to commit. > Tessellator should throw an error if all points were not processed > ------------------------------------------------------------------ > > Key: LUCENE-8549 > URL: https://issues.apache.org/jira/browse/LUCENE-8549 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox > Affects Versions: 7.6, master (8.0) > Reporter: Ignacio Vera > Priority: Blocker > Attachments: LUCENE-8549.patch > > > Currently, the tessellation in some situations when it has not successfully > process all points in the polygon, it will still return an incomplete/wrong > tessellation. > For example the following code: > {code:java} > public void testInvalidPolygon() throws Exception { > String wkt = "POLYGON((0 0, 1 1, 0 1, 1 0, 0 0))"; > Polygon polygon = (Polygon)SimpleWKTShapeParser.parse(wkt); > expectThrows( IllegalArgumentException.class, () -> > {Tessellator.tessellate(polygon); }); > }{code} > will fail as the tessellator return a wrong tessellation containing one > triangle. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org