[ https://issues.apache.org/jira/browse/SOLR-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675570#comment-16675570 ]
Bar Rotstein edited comment on SOLR-12955 at 11/5/18 6:40 PM: -------------------------------------------------------------- {quote}I believe there will be no change to configs and back-compat. People configure a factory, and that factory can in turn instantiate one thing or another depending on ZK.{quote} Would we want CdcrUpdateProcessorFactory to throw an exception if the cluster is not Zookeeper enabled? OR perhaps just return an instance of DistributedUpdateProcessor? was (Author: brot): {quote}I believe there will be no change to configs and back-compat. People configure a factory, and that factory can in turn instantiate one thing or another depending on ZK.{quote} Would we want CdcrUpdateProcessorFactory to throw an exception if the cluster is not Zookeeper enabled? > Refactor DistributedUpdateProcessor > ----------------------------------- > > Key: SOLR-12955 > URL: https://issues.apache.org/jira/browse/SOLR-12955 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Bar Rotstein > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Lately As I was skimming through Solr's code base I noticed that > DistributedUpdateProcessor has a lot of nested if else statements, which > hampers code readability. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org