[
https://issues.apache.org/jira/browse/SOLR-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680426#comment-16680426
]
David Smiley commented on SOLR-12962:
-------------------------------------
The patch looks good Hoss; nice work!
* FieldType.getUninversionMap: why do you propose that it would be nice to
throw an error here? I think returning null is quite correct -- it's how we
communicate the field should not be uninverted.
I know it's too late but I wonder what it would look like to conceive of this
setting as a special docValuesFormat instead -- an uninverting docValuesFormat.
I think long ago when docValues first appeared that could have been more
viable since it would have been how we communicate to uninvert a field. But
with today's legacy concerns, that would just create back-compat pain since
you'd have to go set docValues=true docValuesFormat=UNINVERT on all fields you
want to uninvert when migrating a schema to such a setting.
> add an 'uninvertible' field(type) option (that defaults to "true" for
> backcompat)
> ---------------------------------------------------------------------------------
>
> Key: SOLR-12962
> URL: https://issues.apache.org/jira/browse/SOLR-12962
> Project: Solr
> Issue Type: Sub-task
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Major
> Fix For: 7.6, master (8.0)
>
> Attachments: SOLR-12962.patch, SOLR-12962.patch, SOLR-12962.patch,
> SOLR-12962.patch
>
>
> field & fieldtype declarations should support an {{uninvertible}} option
> (which defaults to "true") for backcompat that dictates wether or not
> Uninversion can be performed on fields.
> See parent issue for more background/discussion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
