Github user jimczi commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/495#discussion_r232193904
  
    --- Diff: 
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
    @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOException {
         return score;
       }
     
    +  @Override
    +  public void setMinCompetitiveScore(float minScore) throws IOException {
    +    float minScoreDown = Math.nextDown(minScore);
    --- End diff --
    
    And for the record, 
[here](https://github.com/apache/lucene-solr/blob/8d7d5aefd477dc86a35cc3eb137a8a45534db285/lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java#L244)
 is where we set the minimum score to the next float. The `AssertingScorable` 
just delegate the call to the underlying scorer.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to