[ 
https://issues.apache.org/jira/browse/SOLR-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681411#comment-16681411
 ] 

Gus Heck commented on SOLR-12976:
---------------------------------

{quote}document that you no longer can use property substitution for secrets
{quote}
That's an enormous break with back compatibility. I rather suspect one of the 
main reasons people pass in secretive things as system props is to substitute 
them in config. As I implied on the user list, I think it's pretty questionable 
to give someone access to admin interface and admin api's (and therefore all 
your data) and then try to hide stuff from them. What's the use case driving 
this?

> Unify RedactionUtils and metrics hiddenSysProps settings
> --------------------------------------------------------
>
>                 Key: SOLR-12976
>                 URL: https://issues.apache.org/jira/browse/SOLR-12976
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: security
>            Reporter: Jan Høydahl
>            Priority: Major
>
> System properties can contain sensitive data, and they are easily available 
> from the Admin UI (/admin/info/system) and also from the Metrics API 
> (/admin/metrics).
> By default the {{/admin/info/system}} redacts any sys prop with a key 
> containing *password*. This can be configured with sysprop 
> {{-Dsolr.redaction.system.pattern=<regex>}}
> The metrics API by default hides these sysprops from the API output:
> {code:java}
>     "javax.net.ssl.keyStorePassword",
>     "javax.net.ssl.trustStorePassword",
>     "basicauth",
>     "zkDigestPassword",
>     "zkDigestReadonlyPassword"
> {code}
> You can redefine these by adding a section to {{solr.xml}}: 
> ([https://lucene.apache.org/solr/guide/7_5/metrics-reporting.html#the-metrics-hiddensysprops-element])
> {code:xml}
> <metrics>
>  <hiddenSysProps>
>    <str>foo</str>
>    <str>bar</str>
>    <str>baz</str>
>  </hiddenSysProps>
> </metrics>{code}
> h2. Unifying the two
> It is not very user firiendly to have two different systems for redacting 
> system properties and two sets of defaults. This goals of this issue are
>  * Keep only one set of defaults
>  * Both metrics and system info handler will use the same source
>  * It should be possible to change and persist the list without a full 
> cluster restart, preferably though some API
> Note that the {{solr.redaction.system.pattern}} property is not documented in 
> the ref guide, so this Jira should also fix documentation!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to