Should I try and get a new patch for SOLR-629 working with 7.x? https://issues.apache.org/jira/browse/SOLR-629
Previous patches have been ignored, so I’d like somebody to promise to look at it. Getting those changes into the edismax code makes my brain hurt. wunder Walter Underwood [email protected] http://observer.wunderwood.org/ (my blog) > On Nov 9, 2018, at 9:43 AM, Chris Hostetter <[email protected]> wrote: > > > : I don't have any problem waiting until tomorrow to cut the branch. I > : noticed a patch was just committed so let me know if you happen to resolve > : this sooner than expected. > > Heh .. yeah, since I didn't hear back from you I stayed up a little later > then usual the last 2 nights re-reviewing everything (that and the > patch review from smiley gave me some re-assurance.) > > (As far as SOLR-12962 is concerned) Feel free to cut branch_7_6 whenever > you're ready. > > > > > : On Thu, Nov 8, 2018 at 3:59 PM Chris Hostetter <[email protected]> > : wrote: > : > : > > : > : Let me know if there are any other blockers that need to be resolved > : > prior > : > : to cutting the branch. If not, I will plan to cut the branch on Friday > or > : > : (provided they are close to resolution) whenever these issues are > : > resolved. > : > > : > nknize: I'd like to try and get SOLR-12962 into 7.6... > : > > : > It's a new "opt in" feature, but one that should help prevent a lot of > : > performance problems for people who want to try it out -- so I'd really > : > like to release it ASAP so we can hopefully get feedback from folks who > : > try it in time to consider changing the default to "opt out" ~8.0 (see > : > SOLR-12963 and parent SOLR-8273 for background) > : > > : > The patch is currently feature complete -- the only 'nocommits' are for > : > updating a small amount of documentation, which I should have done > : > sometime thursday morning (GMT-0700). > : > > : > I'm currently having my machine hammer on the tests, and waiting/hoping > : > for some patch review / sanity checks. > : > > : > > : > My typically "personal workflow based on comfort level" for a change like > : > this would be to do nothing but testing & self-review for at least a day > : > before committing & backporting ... which would mean wrapping it up > : > sometime friday afternoon (GMT-0700). > : > > : > Unless there are any objections, I'd appreciate knowing if either: > : > > : > 1) You would be ok holding off on cutting branch_7_6 until > : > sometime *after* friday ? > : > > : > 2) Folks would be ok w/me backporting SOLR-12962 to banch_7_6 after > : > you fork it (even though it's a new feature, not a blocker bug fix) ? > : > > : > > : > Thoughts? Concerns? > : > > : > > : > > : > > : > -Hoss > : > http://www.lucidworks.com/ > : > > : > --------------------------------------------------------------------- > : > To unsubscribe, e-mail: [email protected] > : > For additional commands, e-mail: [email protected] > : > > : > -- > : > : Nicholas Knize, Ph.D., GISP > : Geospatial Software Guy | Elasticsearch > : Apache Lucene Committer > : [email protected] > : > > -Hoss > http://www.lucidworks.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
