[ 
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682665#comment-16682665
 ] 

Erick Erickson commented on SOLR-12881:
---------------------------------------

So how is precommit passing with all these unused imports?

Is there something about Java 8 that is magic that precommit doesn't take into 
account? For instance, FrenchLightStemmerFilterFactory has the line:

return new FrenchLightStemFilter(input)

Yet importing org.apache.lucene.analysis.fr.FrenchLightStemFilter apparently 
isn't necessary to compile at least.

I applied this patch and it all compiles, so I'm puzzled. I'm running some 
other tests ATM, but I'll run precommit and the full test suite this evening.

 

> Remove unneeded import statements
> ---------------------------------
>
>                 Key: SOLR-12881
>                 URL: https://issues.apache.org/jira/browse/SOLR-12881
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (8.0)
>            Reporter: Peter Somogyi
>            Priority: Trivial
>         Attachments: SOLR-12881.patch, SOLR-12881.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are unnecessary import statements:
>  * import from java.lang
>  * import from same package
>  * unused import



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to